Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ethernet support #1402

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Update Ethernet support #1402

merged 1 commit into from
Jul 11, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Add support for boards that have a GPIO pin that switches the PHY power
Currently enabled by defines.

Removed some old test code.

TODO : Have some header file to have board specific configuration data in so we can have ESP32 community targets.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy<adriansoundy.gmail.com>

@nfbot
Copy link
Member

nfbot commented Jul 11, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement labels Jul 11, 2019
@josesimoes
Copy link
Member

This looks like a board configuration and quite "static" so a good place would be target_common.h.in.

Unless it makes more sense to have it as a build options... not enterely sure about that...

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit f64c4db into nanoframework:develop Jul 11, 2019
@AdrianSoundy AdrianSoundy deleted the Esp32-ethernet-updates branch July 30, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants