Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Managed heap allocator #1393

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Update Managed heap allocator #1393

merged 1 commit into from
Jul 3, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Change to prepare for Spi Ram
Will attempt to allocate managed heap from SPI RAM ( Max size - 256K)
If not available ( current state ) it will allocate 64K from normal RAM as it does now.

How Has This Been Tested?

Tested with debugger to check working OK.
Tested Spi Ram with newer IDF libraries ( not ready yet )

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy <adriansoundy @gmail.com>

@nfbot
Copy link
Member

nfbot commented Jul 3, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! making progresses as always!! 👏 👍

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement labels Jul 3, 2019
@josesimoes josesimoes merged commit 63f1eb6 into nanoframework:develop Jul 3, 2019
@AdrianSoundy AdrianSoundy deleted the Memory-spi branch July 3, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants