Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MDP to output detailed error messages #1361

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Add support for MDP to output detailed error messages #1361

merged 1 commit into from
Jun 12, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add new functions to store messages required for MDP to output error descriptions.
  • Add new variant of NANOCLR_MSG1_SET_AND_LEAVE to work with chars (NANOCLR_CHARMSG_SET_AND_LEAVE).
  • Fix NANOCLR_MSG1_SET_AND_LEAVE define to properly use variable arguments.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Jun 12, 2019
@nfbot
Copy link
Member

nfbot commented Jun 12, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Add support for MDP to output detailed error messages
d324db4 
- Add new functions to store messages required for MDP to output error descriptions.
- Add new variant of NANOCLR_MSG1_SET_AND_LEAVE to work with chars (NANOCLR_CHARMSG_SET_AND_LEAVE).
- Fix NANOCLR_MSG1_SET_AND_LEAVE define to properly use variable arguments.
- Addresses nanoframework/Home#174.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes merged commit 3314383 into develop Jun 12, 2019
@josesimoes josesimoes deleted the work-174 branch June 12, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot