Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CurrentDateTime dropping microseconds #1357

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

josesimoes
Copy link
Member

Description

  • When converting from timeval struct the tv_usec field was being ignored.

Motivation and Context

How Has This Been Tested?

  • Test code from issue.
  • Output is now:
------------------------------------------------------
===== Incrementing time with  500 milliseconds ======
DateTime from reference      : 1970-01-01T12:16:23.016
DateTime from template string: 1970-01-01T12:16:22.019
DateTime from components     : 1970- 1- 1T 0:16:22. 19
------------------------------------------------------
===== Incrementing time with  500 milliseconds ======
DateTime from reference      : 1970-01-01T12:10:26.887
DateTime from template string: 1970-01-01T12:16:22.019
DateTime from components     : 1970- 1- 1T 0:16:22. 19
------------------------------------------------------
===== Incrementing time with  500 milliseconds ======
DateTime from reference      : 1970-01-01T12:10:33.883
DateTime from template string: 1970-01-01T12:16:22.019
DateTime from components     : 1970- 1- 1T 0:16:22. 19
------------------------------------------------------

Screenshots

image

image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- When converting from timeval struct the tv_usec field was being ignored.
- Fixes nanoframework/Home#/483.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: bug Series: ESP32 Everything related specifically with ESP32 series targets labels Jun 11, 2019
@nfbot
Copy link
Member

nfbot commented Jun 11, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit f4ac48e into nanoframework:develop Jun 11, 2019
@josesimoes josesimoes deleted the fix-date-time-esp32 branch June 11, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with DateTime milliseconds ToString
2 participants