Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework UART for TI SimpleLink #1323

Merged
merged 1 commit into from
May 16, 2019
Merged

Rework UART for TI SimpleLink #1323

merged 1 commit into from
May 16, 2019

Conversation

josesimoes
Copy link
Member

Description

  • UART is not initialized and configured in main thread so it's available ASAP.
  • Move UART configuration from WP source to target PAL.
  • Remove check for initialized UART in WP functions.
  • Rework GenericPort_Write to output to UART when the debugger is not attached.

Motivation and Context

  • UART can now be used to output message which is useful for debug.
  • UART init and config is now performed earlier to simplify things.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Rework UART for TI SimpleLink
0be7576 
- UART is not initialized and configured in main thread so it's available ASAP to output.
- Move UART configuration from WP source to target PAL.
- Remove check for initialized UART in WP functions.
- Rework GenericPort_Write to output to UART when the debugger is not attached.

Signed-off-by: José Simões <[email protected]>
@nfbot
Copy link
Member

nfbot commented May 16, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 45162ad into nanoframework:develop May 16, 2019
@josesimoes josesimoes deleted the rework-uart-init branch May 16, 2019 10:33
morali pushed a commit to morali/nf-interpreter that referenced this pull request May 17, 2019
@josesimoes
Rework UART for TI SimpleLink (nanoframework#1323)
8d699df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform: TI-SimpleLink Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot