Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for OpenIfExisting option for CreateFile #1309

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix for OpenIfExisting option for CreateFile #1309

merged 1 commit into from
May 13, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented May 12, 2019 •
edited by josesimoes
Loading

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@nfbot
Copy link
Member

nfbot commented May 12, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: bug labels May 13, 2019
@josesimoes josesimoes merged commit 107845e into nanoframework:develop May 13, 2019
@AdrianSoundy AdrianSoundy deleted the Storage-createfile-fix branch May 18, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows.Storage: CreateFile(..., CreationCollisionOption.OpenIfExists) fails on non-existing file
3 participants
@AdrianSoundy @nfbot @josesimoes