Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement activity heart beat #1262

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add call to events heart beat on Events_WaitForEvents loop.
  • Add compiler defines for EVENTS_HEART_BEAT on target_HAL for all targets
  • Add commented define for events heart beat on all targets.

Motivation and Context

  • When debugging execution engine setting a breakpoint to check for activity is too intrusive and it's not practical. This change adds an none intrusive "heart beat" that can be defined at target level to check for activity. The simplest way is toggling a LED.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@nfbot
Copy link
Member

nfbot commented Mar 14, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Add call to events heart beat on Events_WaitForEvents loop.
- Add compiler defines for EVENTS_HEART_BEAT on target_HAL for all targets
- Add commented define for events heart beat on all targets.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes merged commit 35b8ccb into nanoframework:develop Mar 14, 2019
@josesimoes josesimoes deleted the implement-activity-heartbeat branch March 14, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants