Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cast on socket select. #1260

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Fix cast on socket select. #1260

merged 2 commits into from
Mar 13, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add new variable with copy of timeout value.

Motivation and Context

  • The cast on the timeout parameter was causing issues on STM32 (ARM GCC 7.2) because the value on the second field was randomly being casted to a wrong value thus passing a wrong timeout to the select function. With this fix the platform type dependency is removed.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Mar 13, 2019
@nfbot
Copy link
Member

nfbot commented Mar 13, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 9a27166 into nanoframework:develop Mar 13, 2019
@josesimoes josesimoes deleted the josesimoes-patch-1 branch March 13, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot