Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on managed events #1245

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Work on managed events #1245

merged 1 commit into from
Mar 7, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Moved events defines to nanoHAL_v2 to allow including that on C sources.
  • Wrap PostManagedEvent declaration to make it available on C sources.

Motivation and Context

  • Need to allow C code to post managed events.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Work on events
ce2fd2e 
- Moved events defines to nanoHAL_v2 to allow including that on C sources.
- Wrap PostManagedEvent declaration to make it available on C sources.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries Breaking-change labels Mar 7, 2019
@nfbot
Copy link
Member

nfbot commented Mar 7, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit b9c0f9e into nanoframework:develop Mar 7, 2019
@josesimoes josesimoes changed the title Work on events Work on managed events Mar 7, 2019
@josesimoes josesimoes deleted the work-managed-events branch March 7, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Breaking-change Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot