Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Windows.Storage background thread #1232

Merged

Conversation

josesimoes
Copy link
Member

Description

  • Moved call to Target_FileSystemInit() to nanoHAL_Initialize().
  • Clean up main on CLR to free it from spefics of file system and storage.
  • Add stubs for Windows Storage.
  • Improve code for SD card monitor: now runs on its own thread.
  • Improve code for USB MSD monitor.
  • Add file system init call to ESP32.

Motivation and Context

  • Makes file system and storage initialization transparent to targets, not requiring any specifics on CLR main.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Breaking-change labels Mar 6, 2019
@nfbot
Copy link
Member

nfbot commented Mar 6, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Moved call to Target_FileSystemInit() to nanoHAL_Initialize().
- Clean up main on CLR to free it from spefics of file system and storage.
- Add stubs for Windows Storage.
- Improve code for SD card monitor: now runs on its own thread.
- Improve code for USB MSD monitor.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes force-pushed the improvements-windows-storage branch from f5a8872 to 470fb28 Compare March 6, 2019 19:13
@josesimoes josesimoes merged commit c5f9d45 into nanoframework:develop Mar 6, 2019
@josesimoes josesimoes deleted the improvements-windows-storage branch March 6, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking-change Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants