Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme file to perform as documentation index #12

Merged
merged 5 commits into from
Dec 7, 2016

Conversation

josesimoes
Copy link
Member

No description provided.

@josesimoes
Copy link
Member Author

The last commit was wrongly added to this PR was meant to be a separate on.
It's just a file rename (and corresponding update on the script) to help clarify it's purpose.

@cw2
Copy link
Contributor

cw2 commented Dec 6, 2016

Do you want to merge this with the last commit? It can be removed if needed - just reset the branch to previous commit and push --force.

While in most cases 'force push' is bad, in this particular scenario it's not a big deal, as it is your branch and most likely not shared with others.

@josesimoes
Copy link
Member Author

shhh.... if you don't tell anyone I think this can safely go along with the other commits... 😉

# nanoFramework Documentation

[Building nanoFramework] (build-instructions.md)
[Debug with VS Code] (vscode-debug-instructions.md)
Copy link
Contributor

@cw2 cw2 Dec 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two links are rendered on the same line - wouldn't it be better to use a list instead? Also, the space between '[' and '(' does not work in Visual Studio Code markdown preview.

😓

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that. I overlooked it and thought that it was an issue with VS Code renderer for md files... my bad!

- rework formating to correct erros in the markup
- improve some styling with lists and names
- rename readme files to upper case to follow GitHub common practices
@josesimoes
Copy link
Member Author

I've taken the opportunity to add documentation on some of the CMake modules and files as a walkthrough to help someone that want's to work on this part.
They aren't all documented but it's a start.

@cw2 cw2 merged commit 6bfaa36 into nanoframework:dev-cmake-build Dec 7, 2016
nfbot pushed a commit that referenced this pull request Jan 15, 2024
…580c-196b-48c8-9817-cca5540acfc8

Code style fixes for nanoframework/nf-interpreter PR#2849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants