Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep sleep for Esp32 fix #1157

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Deep sleep for Esp32 fix #1157

merged 1 commit into from
Jan 19, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

When deep sleep is being executed the interpreter seems to be stuck in schedule threads and doesn't exit so that power level can be changed.

It looked like the Schedule threads continues to run after executing the managed Deep sleep command, probably just finishing its quantum.

Added a return code of CLR_E_THREAD_WAITING in the Deep sleep call to force thread to stop running. This now seems to reliably exit the scheduler and run the deep sleep. Not sure why it was working when last tested.

May need similar change on STM32

Motivation and Context

Broken

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@nfbot
Copy link
Member

nfbot commented Jan 19, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy merged commit 9e66eb1 into nanoframework:develop Jan 19, 2019
@AdrianSoundy AdrianSoundy changed the title Deep sleep fix for Esp32 fix Deep sleep for Esp32 fix Jan 19, 2019
@AdrianSoundy AdrianSoundy deleted the deep-sleep-fix branch January 19, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants