Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetChannel in PWM #1146

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Fix GetChannel in PWM #1146

merged 2 commits into from
Jan 9, 2019

Conversation

sjmneves
Copy link
Contributor

@sjmneves sjmneves commented Jan 9, 2019

Description

  • GetChannel now returns -1 if no channel found for pin/timer combination.

How Has This Been Tested?

  • Tested with nf Samples PWM

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sjmneves [email protected]

@nfbot
Copy link
Member

nfbot commented Jan 9, 2019

Hi @sjmneves,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Fix GetChannel Fix GetChannel in PWM Jan 9, 2019
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jan 9, 2019
@sjmneves @josesimoes
Fix PWM config depending on STM32_PWM_USE_ADVANCED
f5446c0
@sjmneves @josesimoes
Fix GetChannel
41e71ef 
- GetChannel now returns -1 if no channel found for pin/timer combination
@josesimoes josesimoes merged commit eb47e39 into nanoframework:develop Jan 9, 2019
@josesimoes josesimoes deleted the work-stm32-pwm branch January 9, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjmneves @nfbot @josesimoes