Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect buffer assignment in 1-wire low-level code #1142

Merged

Conversation

sharmavishnu
Copy link
Contributor

Corrected assignment of receive buffer to the ONEWIRED driver.

Incorrect assignment of same buffer to both transmit buffer and receive buffer.

Description

Updated code to correctly assign receive buffer array to the receive buffer of the 1-wire driver.

Motivation and Context

TouchReset was returning false, even when device was successfully detected on the 1-wire bus. Upon code inspection, it revealed that there was a minor copy/paste error, where the transmit buffer was assigned to both the receive buffer container and the transmit buffer container of the 1-wire driver structure.

How Has This Been Tested?

Code was tested with UART1 on STM32F401RE Nucleo board.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: @sharmavishnu

Corrected assignment of receive buffer to the ONEWIRED driver.
@nfbot
Copy link
Member

nfbot commented Jan 8, 2019

Hi @sharmavishnu,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jan 8, 2019
@josesimoes josesimoes merged commit a672af7 into nanoframework:develop Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants