Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConfigurationManager_StoreConfigurationBlock for ESP32 #1091

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Fix ConfigurationManager_StoreConfigurationBlock for ESP32 #1091

merged 2 commits into from
Dec 12, 2018

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • Was using a wrong char to find Network config block.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Fix ConfigurationManager_StoreConfigurationBlock for ESP32
5a2643a 
- Was using a wrong char to find Network config block.
@josesimoes josesimoes added Type: bug Series: ESP32 Everything related specifically with ESP32 series targets labels Dec 10, 2018
@nfbot
Copy link
Member

nfbot commented Dec 10, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

Actually this should be using constants or #defines instead of "magic" strings for comparisons, isn't it?

@josesimoes josesimoes requested review from MatthiasJentsch and removed request for AdrianSoundy December 11, 2018 13:52
MatthiasJentsch
MatthiasJentsch approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@MatthiasJentsch MatthiasJentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.

@josesimoes josesimoes merged commit 4d043b7 into develop Dec 12, 2018
@josesimoes josesimoes deleted the josesimoes-patch-1 branch December 12, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthiasJentsch MatthiasJentsch MatthiasJentsch approved these changes

Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josesimoes @nfbot @MatthiasJentsch