Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct buffer size for ST_NUCLEO_F091RC #102

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Conversation

josesimoes
Copy link
Member

  • fixes #101

Signed-off-by: José Simões [email protected]

- fixes #101

Signed-off-by: José Simões <[email protected]>
@cw2
Copy link
Contributor

cw2 commented Jan 31, 2017

I have not yet checked all the details, but isn't the problem really that a packed can be received while previous one has not been processed yet? I think there is a mechanism that prevents that in the orginal NETMF implementation (something along 'set buffer in use' flag)?

@josesimoes
Copy link
Member Author

It's in the TX and it's solved. The buffer size got changed when moving from the test app.
This is at the phy layer. There is nothing NETMF layers above can do about it by the time it reaches there.

@cw2 cw2 merged commit 20274e1 into nanoframework:master Jan 31, 2017
@josesimoes josesimoes deleted the fix-101 branch February 16, 2017 12:05
nfbot added a commit that referenced this pull request Aug 30, 2023
Automated fixes for code style.
nfbot pushed a commit that referenced this pull request Jan 24, 2024
…c16a5-373a-433e-8de5-797311ab4f98

Code style fixes for nanoframework/nf-interpreter PR#2829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants