Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retries argument from all methods #73

Merged
merged 1 commit into from
Oct 31, 2017

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Oct 31, 2017

Description

  • Remove retries argument from all methods
  • Remove RebootTime class and update code accordingly
  • Typos correction
  • Clean up code
  • Update test apps

Motivation and Context

  • Because of improved channel and communication reliability this doesn't make sense anymore. Any retry strategy should be carried out by the caller.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- Because of improved channel and communication reliability this doesn't make sense anymore
- Remove `RebootTime` class and update code accordingly
- Typos correction
- Clean up code
- Update test apps

Signed-off-by: José Simões <[email protected]>
@nfbot
Copy link
Member

nfbot commented Oct 31, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 30e20e9 into nanoframework:develop Oct 31, 2017
@josesimoes josesimoes deleted the remove-retries branch October 31, 2017 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants