Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Ports and PortManagers #330

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Work Ports and PortManagers #330

merged 1 commit into from
Nov 30, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Rename network watcher and other network classes for consistency.
  • DeviceWatchers now are aware of the owning managers.
  • Add debug information on watchers start & stop events.
  • Remove usings and tidy up code.

Motivation and Context

  • Improve code quality.
  • Improve output details to help debugging.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Rename network watcher and other network classes for consistency.
- DeviceWatchers now are aware of the owning managers.
- Add debug information on watchers start & stop events.
- Remove usings and tidy up code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants