Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in EraseAsync #286

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Code has been optimized to prevent duplicated and needless calls to device ping.
  • GetConnectionSource now also updates the ConnectionSource field.
  • Update test app.

Motivation and Context

  • Improve erase operation efficiency.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Code has been optimized to prevent duplicated and needless calls to device ping.
- GetConnectionSource now also updates the ConnectionSource field.
- Update test app.
@josesimoes josesimoes merged commit 3c7a1f4 into nanoframework:develop Dec 17, 2020
@josesimoes josesimoes deleted the improvements-erase-connect branch December 17, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants