Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on async calls #278

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Rework SendBuffer and ReadBuffer to remove async calls and to throw DeviceNotConnectedException exception.
  • Rework initial SerialDevice detection.
  • Remove Async suffix from several APIs.
  • Bump version to 1.25.0-preview.

Motivation and Context

  • Improve stability on the communication an discovery of devices.

How Has This Been Tested?

  • Test apps in solution.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Rework SendBuffer and ReadBuffer to remove async calls and to throw DeviceNotConnectedException exception.
- Rework initial SerialDevice detection.
- Remove Async suffix from several APIs.
- Bump version to 1.25.0-preview.
@josesimoes josesimoes merged commit 90531e0 into nanoframework:develop Nov 26, 2020
@josesimoes josesimoes deleted the rework-async-calls branch November 26, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants