Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ToString of NanoFrameworkDeviceInfo #215

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Improve ToString of NanoFrameworkDeviceInfo #215

merged 1 commit into from
Feb 13, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add null checks to several properties.

Motivation and Context

  • Improve code robustness.

How Has This Been Tested?

  • UWP test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Improve ToString of NanoFrameworkDeviceInfo
c4f01f7 
- Add null checks to several properties.

Signed-off-by: José Simões <[email protected]>
@nfbot
Copy link
Member

nfbot commented Feb 13, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes merged commit 3fb4e1d into nanoframework:develop Feb 13, 2020
@josesimoes josesimoes deleted the improve-tostring-deviceinfo branch February 13, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot