Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serial target detection #211

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

josesimoes
Copy link
Member

Description

  • On serial devices we are now attempting connecting with three different baud rates.
  • Supported baud rates are: 921600, 460800, 115200.
  • Bump version to 1.5.0-preview.

Motivation and Context

  • This is to accommodate targets connected through serial with low specs that can't perform that well with high baud rates.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@nfbot
Copy link
Member

nfbot commented Oct 9, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- On serial devices we are now attempting connecting with three different baud rates.
- This is to accomodate devices with low specs that can't perform that well on high baud rates.
- Bump version to 1.5.0-preview.

Signed-off-by: José Simões <[email protected]>
@josesimoes
Copy link
Member Author

SonarCloud failing on lack of code coverage. Ignoring.

@josesimoes josesimoes merged commit 7c017eb into nanoframework:develop Oct 9, 2019
@josesimoes josesimoes deleted the improve-serial-constructor branch October 9, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants