Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PlatformCapabilities and TargetCapabilities to CLRCapabilities #202

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Add PlatformCapabilities and TargetCapabilities to CLRCapabilities #202

merged 1 commit into from
Jun 27, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add these to NanoFrameworkDeviceInfo and interface.
  • Add target capabilites enum for all available platforms.
  • Update test app with these.

Motivation and Context

  • With these new data fields targets can report capabilities specific to the platform and to the target. Having them as general flags wouldn't work as that would be a waste of space because of the differences between platforms and targets. Having them generic allows for those differences and the real meaning is figured out by an upper layer.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Add PlatformCapabilities and TargetCapabilities to CLRCapabilities
3d6b73e 
- Add these to NanoFrameworkDeviceInfo and interface.
- Add target capabilites enum for all available platforms.
- Update test app with these.

Signed-off-by: José Simões <[email protected]>
@nfbot
Copy link
Member

nfbot commented Jun 27, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

SonarCloud check failing on low coverage. Ignoring.

@josesimoes josesimoes merged commit de297ff into nanoframework:develop Jun 27, 2019
@josesimoes josesimoes deleted the add-target-platform-capabilities branch June 27, 2019 08:52
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 27, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
c853b9a 
- Following nanoframework/nf-debugger#202.
- Add new header with placeholder for platform and target capabilites.
- Add enum with target capabilities for STM32 targets.
- Add target declaration to ND3 and QUAIL.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes mentioned this pull request Jun 27, 2019
Merged
10 tasks
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 27, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
2241d43 
- Following nanoframework/nf-debugger#202.
- Add new header with placeholder for platform and target capabilites.
- Add enum with target capabilities for STM32 targets.
- Add target declaration to ND3 and QUAIL.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jun 27, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
9cb2323 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jun 27, 2019
@josesimoes
Add TargetCapabilities
d0c12c5 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 9, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
523b31d 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 9, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
04f985a 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 9, 2019
@josesimoes
Add TargetCapabilities
c3062a2 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 10, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
2a047ee 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
jakubstandarski pushed a commit to jakubstandarski/nf-interpreter that referenced this pull request Jul 11, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
3b62836 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 12, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
1958ae2 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 12, 2019
@josesimoes
Add TargetCapabilities
cca79eb 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
jakubstandarski pushed a commit to jakubstandarski/nf-interpreter that referenced this pull request Jul 15, 2019
@MateuszKlatecki
Add PlatformCapabilities and TargetCapabilities
dad436b 
- Following nanoframework/nf-debugger#202.
jakubstandarski pushed a commit to jakubstandarski/nf-interpreter that referenced this pull request Jul 15, 2019
@MateuszKlatecki
Add PlatformCapabilities and TargetCapabilities
9fcde5b 
- Following nanoframework/nf-debugger#202.
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 16, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
4495a91 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 18, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
778cd78 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 18, 2019
@josesimoes
Add TargetCapabilities
266ee72 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 22, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
f8c0dda 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 22, 2019
@josesimoes
Add TargetCapabilities
0d90905 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 23, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
b96e5fd 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 23, 2019
@josesimoes
Add TargetCapabilities
390697a 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 24, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
52766d5 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Jul 24, 2019
@josesimoes
Add TargetCapabilities
14b6809 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Aug 26, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
96f97af 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Aug 26, 2019
@josesimoes
Add TargetCapabilities
14d3823 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Aug 27, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
58c5479 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
morali pushed a commit to morali/nf-interpreter that referenced this pull request Oct 4, 2019
@MateuszKlatecki
Add PlatformCapabilities and TargetCapabilities
5d91739 
- Following nanoframework/nf-debugger#202.
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 17, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
e4056c1 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 17, 2019
@josesimoes
Add TargetCapabilities
c6168e3 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 18, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
753c2ef 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 18, 2019
@josesimoes
Add TargetCapabilities
b583fa8 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 23, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
bbcc701 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 23, 2019
@josesimoes
Add TargetCapabilities
cdd3665 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 30, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
d981eca 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Oct 30, 2019
@josesimoes
Add TargetCapabilities
926a1bb 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Nov 5, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
556d177 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Nov 5, 2019
@josesimoes
Add TargetCapabilities
50da71e 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Nov 8, 2019
@josesimoes
Add TargetCapabilities
d2c94da 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Nov 8, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
ccfe8c4 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Nov 14, 2019
@josesimoes
Add PlatformCapabilities and TargetCapabilities
03f5d48 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Nov 14, 2019
@josesimoes
Add TargetCapabilities
c59240f 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Nov 27, 2019
@josesimoes
Add TargetCapabilities
d9366c9 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Feb 7, 2020
@josesimoes
Add TargetCapabilities
396bf9e 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Feb 25, 2020
@josesimoes
Add TargetCapabilities
4b1f313 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to nanoframework/nf-interpreter that referenced this pull request Mar 9, 2020
@josesimoes
Add TargetCapabilities
fe1292c 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jul 15, 2020
@josesimoes
Add TargetCapabilities
2c1f42c 
- Following nanoframework/nf-debugger#202.

Signed-off-by: José Simões <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot