Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting configuration blocks #187

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Fix getting configuration blocks #187

merged 2 commits into from
Mar 8, 2019

Conversation

sjmneves
Copy link
Contributor

@sjmneves sjmneves commented Mar 8, 2019 •
edited by josesimoes
Loading

Description

  • Fix getting configuration blocks.

Motivation and Context

  • Solve infinity loop when getting configuration blocks.

How Has This Been Tested?

  • Tested with Debugger Tools Test App.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sjmneves [email protected]

@nfbot
Copy link
Member

nfbot commented Mar 8, 2019

Hi @sjmneves,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Fix get configuration blocks Fix getting configuration blocks Mar 8, 2019
josesimoes
josesimoes approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👏

@josesimoes josesimoes merged commit 979112b into nanoframework:develop Mar 8, 2019
@josesimoes josesimoes deleted the fix-get-config-blocks branch March 8, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjmneves @nfbot @josesimoes