Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename property to disambigue name with comercial service #137

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Rename property to disambiguate name with comercial service

Motivation and Context

  • Clear potential confusion with DynDNS service

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@nfbot
Copy link
Member

nfbot commented Apr 20, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Clear potential confusion with DynDNS service

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes merged commit a15b4d8 into nanoframework:develop Apr 20, 2018
@josesimoes josesimoes deleted the update-property branch April 20, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants