Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Rename several asserts to match with official MS Test framework.
  • Add obsolete attribute to the old ones.
  • Rename several parameters to match official API.
  • Add missing parameters to Intellisense comments.
  • Rework most of Intellisense comments to match official docs.
  • Add new class CollectionAsserts.

Motivation and Context

  • Align API with Microsoft Test Framework.
  • General improvements in Intellisense comments.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Rename several asserts to match with official MS Test framework.
- Add obsolete attribute to the old ones.
- Rename several parameters to match official API.
- Add missing parameters to Intellisense comments.
- Rework most of Intellisense comments to match official docs.
- Add new class CollectionAsserts.
@josesimoes josesimoes merged commit 6495f58 into nanoframework:main Dec 14, 2022
@nfbot nfbot added invalid This doesn't seem right and removed Type: enhancement Type: documentation labels Dec 14, 2022
@josesimoes josesimoes deleted the rework-asserts branch December 14, 2022 15:26
@josesimoes josesimoes added Type: enhancement Type: documentation and removed invalid This doesn't seem right labels Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants