Skip to content

Conversation

@torbacz
Copy link
Contributor

@torbacz torbacz commented Jun 6, 2022

Description

  • Switched name of test from method name with params to method name with index corresponding to order of DataRow attributes.
  • Ignoring TestMethod attribute if DataRow exists

Motivation and Context

How Has This Been Tested?

Ran tests on emulator and ESP32
image

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot changed the title Fix few issues with DataRow implementation. Fix few issues with DataRow implementation Jun 6, 2022
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! 💯 👏🏻

@josesimoes josesimoes enabled auto-merge (squash) June 6, 2022 16:17
@josesimoes josesimoes merged commit 79f22fb into nanoframework:main Jun 6, 2022
@torbacz torbacz deleted the fixDataRowIssues branch June 6, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestFramework - unable to run tests with long string in parameters TestFramework - unable to run tests with "," in parameters

3 participants