Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Debug.WriteLine() instead of DebugHelper #3

Merged
merged 2 commits into from
May 27, 2020
Merged

Use Debug.WriteLine() instead of DebugHelper #3

merged 2 commits into from
May 27, 2020

Conversation

skigrinder
Copy link
Contributor

@skigrinder skigrinder commented May 26, 2020

Now using Debug.WriteLine() instead of DebugHelper

Description

Debug.WriteLine() was recently added to nanoFramework as part of the nanoFramework.Runtime.Native NuGet. This PR changes all debug output to Debug.WriteLine(). The DebugHelper class has been removed

How Has This Been Tested?

  • The Json.Test utility is included in this package
  • All tests pass except the Float test for NaN

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: skigrinder [email protected]

@nfbot
Copy link
Member

nfbot commented May 26, 2020

Hi @skigrinder,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@networkfusion
Copy link
Member

LGTM

@networkfusion networkfusion changed the title Now using Debug.WriteLine() instead of DebugHelper Use Debug.WriteLine() instead of DebugHelper May 27, 2020
Copy link
Member

@networkfusion networkfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@networkfusion networkfusion merged commit 4d0662e into nanoframework:develop May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants