Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and fixes #108

Merged
merged 6 commits into from
Jun 5, 2021
Merged

Improvements and fixes #108

merged 6 commits into from
Jun 5, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Fixes with DateTime processing.
  • Can handle 0001-01-01T00:00:00Z as the "null" value for DateTime.
  • Can handle wrong encoded data from Azure Twins.
  • Add workaround for Azure Twins properties starting with $
  • Tries to find a property whose name starts with a _ instead.
  • Update Unit Tests to cover these.
  • Add new test classes to cover this.
  • Improve handling of nested hastables.

Motivation and Context

  • Need to properly parse Azure Twins json payload.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Can handle 0001-01-01T00:00:00Z as the "null" value for DateTime.
- Can handle wrong encoded data from Azure Twins.
- Tries to find a property whose name starts with a _ instead.
- Update Unit Tests to cover these.
- Add new test classes to cover this.
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for the improvments!

@josesimoes josesimoes merged commit 9c24a7a into develop Jun 5, 2021
@josesimoes josesimoes deleted the improvements branch June 5, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants