This repository has been archived by the owner on Apr 19, 2022. It is now read-only.
Add lazy initialization to AdcController #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Nov 22, 2018
- Following nanoframework/Windows.Devices.Adc#31. [version update] ***_NO_CI***
|
@steffalk please hold the review. |
josesimoes
added a commit
to Eclo/nf-interpreter
that referenced
this pull request
Nov 26, 2018
josesimoes
force-pushed
the
add-lazy-init-adccontroller
branch
from
340ccee
to
65388ea
Compare
|
@steffalk it's OK to review this now. |
josesimoes
force-pushed
the
add-lazy-init-adccontroller
branch
from
65388ea
to
2ccc244
Compare
steffalk
reviewed
Nov 26, 2018
steffalk
reviewed
Nov 26, 2018
steffalk
reviewed
Nov 26, 2018
josesimoes
force-pushed
the
add-lazy-init-adccontroller
branch
2 times, most recently
from
ae78429
to
6db4229
Compare
- Add lazy initialization to I2cController. - Also changed DeviceCollection making it accessible as property. - Make sure that the variables do exist when being used. Using the previous code was causing issues because, on occasions, the related types could still be unresolved. - Add AdcControllerManager allowing multiple ADC controllers. - Decorate fields with DebuggerBrowsableState to hide them on debug session. Signed-off-by: José Simões <[email protected]>
josesimoes
force-pushed
the
add-lazy-init-adccontroller
branch
from
6db4229
to
9324915
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões [email protected]