Change fanout to scale by std::log rather than std::sqrt #4835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit 0b0deccPull Request 4835: Results Test Case Results
Last updated: 2025-01-30 19:21:45 UTC |
pwojcikdev
force-pushed
the
fanout_log
branch
from
770c6f2 to
0b0decc
Compare
|
I rebased it on top of develop after merging #4837 which seems to have fixed it. Looks good. |
not-Ian
reviewed
Jan 31, 2025
| @@ -430,7 +430,8 @@ std::deque<std::shared_ptr<nano::transport::channel>> nano::network::list_non_pr | |||
| // Simulating with sqrt_broadcast_simulate shows we only need to broadcast to sqrt(total_peers) random peers in order to successfully publish to everyone with high probability | |||
There was a problem hiding this comment.
Is this comment out of date after this change?
sqrt(total_peers) should now be log(total_peers), no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.