Woyten's "Make Nannou compile in WASM environment" without old winit/web-sys feature#821
Merged
mitchmindtree merged 3 commits intonannou-org:masterfrom Dec 15, 2021
Conversation
Member
Author
|
Ahh woops, I just noticed #811 covers this, closing in favour of that PR. |
Member
Author
|
Ahh I'm doubly mistaken, #811 is a proof of concept (as the branch says) and still includes this as one of the steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all @Woyten's awesome work in #715 on nannou's WASM compatibility story, but with the
winit/web-sysfeature removed seeing aswinithave themselves also removed the feature.Closes #715.