↩️❓ Add canGoBack to routers
#481
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@dnlgrgly is attempting to deploy a commit to the BeatGig Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -140,6 +140,13 @@ export function useRouter() { | |||
| navigation?.goBack() | |||
| } | |||
| }, | |||
| canGoBack: () => { | |||
| if (Platform.OS === 'web') { | |||
| return window.history?.length && window.history.length > 2 | |||
There was a problem hiding this comment.
This should return a Boolean, right? It also isn’t SSR safe…
There was a problem hiding this comment.
I wonder if we need to use useSyncExternalStore for web
There was a problem hiding this comment.
Hello, I hope you're doing well. I wanted to share my thoughts on this feature. I'm not quite sure how to contribute directly, so I thought I'd leave my suggestion here.
I believe this feature would be great! However, I don’t think we necessarily need to use useSyncExternalStore. A simple check on the browser’s history might be sufficient.
canGoBack: () => {
if (typeof window !== 'undefined' && Platform.OS === 'web') {
return window.history?.length > 1;
} else {
return navigation?.canGoBack();
}
},
I think it'd be nice to expose canGoBack in the Solito useRouter hooks to match React Navigation's capabilities.
canGoBackto check if it's possible to navigate back.I've tested it locally and it seems to work fine both on web and native. This is my first contribution so all feedback is much appreciated 🙌