Upgrade dockerode and fix tagging wrong image #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odino
reviewed
Jun 5, 2017
| @@ -105,6 +106,9 @@ docker.buildImage = function(project, tarPath, imageId, buildId, buildLogger, do | |||
| } | |||
|
|
|||
| buildLogger.info('[%s] %s', tag, result.stream || result.status); | |||
| if (result.stream && result.stream.indexOf('Successfully built ') == 0) { | |||
| realBuildId = result.stream.split('Successfully built ')[1].replace('\n', ''); | |||
There was a problem hiding this comment.
this is very hack-ish, it's prone to error :) maybe check if dockerode provides other ways to give you the image name?
There was a problem hiding this comment.
Couldn't find a cleaner way around it. To avoid potential issue, did set the realBuildId as buildID as initial value.
oba11
force-pushed
the
upgrade-dockerode
branch
2 times, most recently
from
cf11693
to
a018268
Compare
|
closing it to reopen the PR against master |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With the new docker api, there is an issue whereby once an image with
latesttag is built, any image being built afterwards uses the image id of the previously builtlatesttag except thelatesttagged-image is removed.This was because
var image = docker.client.getImage(imageId)used.One new docker API servers, once the
latesttagged-image is built, var image would default to latest imagehub/repo:latestinstead ofhub/repo. On Cli try .Steps to reproduce on cli
docker pull alpine:3.5*
docker image inspect alpine=> You should get an errordocker pull alpine:latest*
docker image inspect alpine=> This should default toalpine:latestThe PR ensures that the images are tagged from the imageID instead of repo-name, then retrieves the image tag which is pushed to the registry