Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NamiSku: Pass enum value for NamiSkuType #43

Merged
merged 1 commit into from
Nov 9, 2023
Merged

NamiSku: Pass enum value for NamiSkuType #43

merged 1 commit into from
Nov 9, 2023

Conversation

cp-sneha-s
Copy link
Collaborator

Changelog

  • I think removing NamiSKUType.name has broken the buySkuComplete flow. As name property on enum is not available on the older versions that we support, I have added an additional method that returns value of the enum.

@namidan namidan self-requested a review November 9, 2023 20:03
@namidan namidan merged commit 6542e3a into main Nov 9, 2023
@namidan namidan deleted the fix-exception-namisku-type branch November 9, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namidan namidan namidan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-sneha-s @namidan