-
Notifications
You must be signed in to change notification settings - Fork 4
feat: improve URI handling by basing it on the libcoap type #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code Coverage ReportGenerated for commit 44d605d on Thu Jul 18 15:34:28 UTC 2024.
|
|
Apparently there seems to be some issue with doctests and the unstable For now, I have disabled these unstable flags and changed the toolchain the tests are run on to stable Rust. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only very few minor comments, but be aware that I'm not that familiar with this repository.
d0f274c to
6a0f90e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the two remaining minor comments, LGTM.
6a0f90e to
9def547
Compare
This PR rewrites the
CoapUritype to work directly with an underlyingcoap_uri_tobject and use the libcoap-provided uri parsing functions.Additionally the
urlcrate is now an optional dependency, and theCoapUritype now implementsFromStr, which allows way easier construction of URIs.Before (using
urlcrate):Before (without
urlcrate):Now: