Implement all miekg/pkcs11 Ctx functions (v2) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRand
changed the title
JeremyRand
force-pushed
the
bernard-complete-ctx-encryptnull-with-null-caching
branch
from
0341682 to
f4e1d24
Compare
Fixes build error triggered by miekg/pkcs11 40e115a85e0196984e45b254c509d74900738bb4
JeremyRand
force-pushed
the
bernard-complete-ctx-encryptnull-with-null-caching
branch
from
d94a606 to
0a827eb
Compare
Fixes build error triggered by miekg/pkcs11 40e115a85e0196984e45b254c509d74900738bb4
JeremyRand
force-pushed
the
bernard-complete-ctx-encryptnull-with-null-caching
branch
5 times, most recently
from
085c91e to
cbe45a0
Compare
JeremyRand
force-pushed
the
bernard-complete-ctx-encryptnull-with-null-caching
branch
from
cbe45a0 to
0ec8883
Compare
JeremyRand
changed the title
|
@bernard-wagner I'm planning on merging this in a few days; feel free to give it a final look-over if you like. Thanks again for the code! |
|
Merged. Thanks, and sorry this took so long! |
|
Awesome! Also really like the improvements you added around caching and null values. |
JeremyRand
deleted the
bernard-complete-ctx-encryptnull-with-null-caching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactorization of #7
Fixes #1