Quick and dirty fix for pause on detach on Android O #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanArmbrust
force-pushed
the
master
branch
2 times, most recently
from
4b1f237
to
914d166
Compare
rivaldi8
reviewed
Dec 31, 2017
| if (PreferencesUtility.getInstance(content).pauseEnabledOnDetach()) { | ||
| pause(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why have you created a new BroadcastReceiver instead of using the existing mIntentReceiver? It looks like you could just have added this code to MusicService.handleCommandIntent.
|
Good point. I've fixed it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Android O, WakefulBroadcastReceiver has been deprecated. As such, the MediaButtonIntentReceiver class no longer functions on Android API 26 or greater. To get around this, I have placed a BroadcastReceiver within the MusicService class to handle pause on detach.
#348