Skip to content

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented May 14, 2025

Describe your changes

Partially handles #4479

Particularly, this PR handles the following:

  • The layout of MASP shielded data is modified to include the hash of a tx extra data section containing a vector of FMD flag ciphertexts.
  • Idem for IBC shielding data (except the FMD flag ciphertexts are included verbatim, as part of ICS-20 memos).
  • Inclusion of a new kind of payment address (zfnam1...) that is nearly structurally identical to the other payment address format (znam1...), with the addition of two compressed ristretto255 elliptic curve points, representing a compact FMD public key.
  • FMD secret key derivation from MASP input viewing keys, and FMD public key randomization via the diversifiers included in payment addresses.
  • Changes to the behavior of the MASP VP, to check for the presence of flag ciphertexts.
  • Emitting FMD flag ciphertext events, for consumption by external tooling (e.g. the MASP indexer).

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 added ledger MASP SDK breaking:consensus Consensus breaking change that requires a hard-fork breaking: tx Transaction format breaking change breaking:SDK SDK breaking change do-not-merge Do not merge for now breaking:api public API breaking change labels May 14, 2025
@sug0 sug0 force-pushed the tiago/fmd-integration branch from e154675 to c9909b7 Compare May 14, 2025 12:46
@sug0 sug0 force-pushed the tiago/fmd-integration branch from c9909b7 to bf609fe Compare May 14, 2025 13:13
@sug0 sug0 force-pushed the tiago/fmd-integration branch from c2d70ce to aef297b Compare May 19, 2025 11:42
@sug0 sug0 force-pushed the tiago/fmd-integration branch 3 times, most recently from 372acc0 to 017554b Compare May 20, 2025 12:49
@sug0 sug0 force-pushed the tiago/fmd-integration branch from 017554b to e8b2722 Compare May 22, 2025 10:21
@sug0
Copy link
Collaborator Author

sug0 commented May 22, 2025

https://github.com/heliaxdev/namada-ci/blob/main/artifacts/app_s2.elf must be updated to fix test-e2e-with-device-automation

@batconjurer batconjurer mentioned this pull request May 23, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change breaking:consensus Consensus breaking change that requires a hard-fork breaking:SDK SDK breaking change breaking: tx Transaction format breaking change do-not-merge Do not merge for now ledger MASP SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant