Skip to content

Conversation

tzemanovic
Copy link
Collaborator

@tzemanovic tzemanovic commented Feb 20, 2025

Describe your changes

Closes #3965

This transaction can be updated with on-chain governance, but excludes SDK and client changes that require this tx to be deployed first (follow-up in #4427)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic force-pushed the tomas/override-rewards-target branch from f4b3b79 to 2c710e0 Compare February 27, 2025 13:26
@tzemanovic tzemanovic marked this pull request as ready for review February 27, 2025 13:29
@github-actions github-actions bot added the breaking:api public API breaking change label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.46%. Comparing base (c29fd32) to head (9b01f9a).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
wasm/tx_claim_rewards/src/lib.rs 0.00% 11 Missing ⚠️
crates/tx_prelude/src/proof_of_stake.rs 0.00% 2 Missing ⚠️
crates/proof_of_stake/src/lib.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4402      +/-   ##
==========================================
- Coverage   74.54%   74.46%   -0.08%     
==========================================
  Files         339      339              
  Lines      110504   110636     +132     
==========================================
+ Hits        82374    82390      +16     
- Misses      28130    28246     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic requested a review from grarco March 3, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support a rewards address when claiming rewards

2 participants