Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve concurrency issues #31

Merged
merged 1 commit into from
May 6, 2024
Merged

Solve concurrency issues #31

merged 1 commit into from
May 6, 2024

Conversation

albyrock87
Copy link
Contributor

  • Throw InvalidNavigationException only when navigating from within another navigation (i.e. from inside an OnAppearingAsync)
  • Properly handle rapid clicks by leveraging the semaphore the right way
  • Correctly detect navigation state through the use of AsyncLocals

@github-actions github-actions bot added the enhancement Issues describing an enhancement or pull requests adding an enhancement. label May 3, 2024
- Throw `InvalidNavigationException` only when navigating from within another navigation (i.e. from inside an `OnAppearingAsync`)
- Properly handle rapid clicks by leveraging the semaphore the right way
- Correctly detect navigation state through the use of `AsyncLocal`s
- Abort navigations triggered on an old navigation state
@albyrock87 albyrock87 merged commit 7e06f56 into main May 6, 2024
5 checks passed
@albyrock87 albyrock87 deleted the solve-concurrency-issues branch May 6, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant