Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

[WIP] New API for Vadi #9

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] New API for Vadi #9

wants to merge 5 commits into from

Conversation

naipotato
Copy link
Owner

@naipotato naipotato commented Nov 12, 2020

This PR brings new names for the methods, and fixes a lot a unexpected behaviours. Also documents the library.

Tasks left:

  • Fix commit history
  • Finish unit tests

With this, #5 is no longer needed

@naipotato naipotato self-assigned this Nov 12, 2020
@naipotato naipotato added this to the 1.0.0 milestone Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #9 (4227e52) into main (19e721a) will decrease coverage by 45.00%.
The diff coverage is 55.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              main       #9       +/-   ##
============================================
- Coverage   100.00%   55.00%   -45.00%     
============================================
  Files            2        2               
  Lines           82       60       -22     
============================================
- Hits            82       33       -49     
- Misses           0       27       +27     
Impacted Files Coverage Δ
lib/vdi-recipe-func-closure.vala 0.00% <0.00%> (ø)
lib/vdi-object-factory.vala 58.92% <58.92%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e721a...4227e52. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant