admin install linux #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto a distro specific interface
…w a 'failure' on the test even if the exception is caught and expected in an assert
…atures from the command line
…imes to properly reflect what the command does better
…n be created on build and are bloat
…ets you pick either runtimes or SDKs, so the old name was technically incorrect even though it was less verbose
…ilson/vscode-dotnet-runtime into nagilson-admin-install-linux
added 3 commits
June 13, 2023 11:28
…d vscode/sudo for sudo commands
… the sudo fuctionality
nagilson
force-pushed
the
nagilson-admin-install-linux
branch
from
0ce832b to
2a8d4cf
Compare
…o be tested more to see command output and results not on admin), and add nornt option to skip building the runtime ext
…it synchronous, add a base implementation for every single command.
installcommand works up to replacing the {0}, which should be fixed now, check runcommand on wsl and such
…sudo command, and fix replacement
… having and forwarding the user password
… api exposed yet)
…Resolver and make it easier to test. Need to fix the remaining bug in detecting if valid or fully specified version
…ions. Pass all tests!
…nsion VSCode added support for no activiation events in vsce with 1.74.0, the vsce package will fail until this update was added to bump vscode engine in the sample extension. VSCE is also deprecated and you must use @vscode/vsce now.
We needed to add the mock executor to the mock distro provider so we could see if it tried to run the install command or the update command. I also added a test to see if things are rejected (when you try to install a lower major.minor than what's already on the machine) but we should see if we want that behavior by checking in with the PMs on the team!
We needed to create a sample extension VSIX for testing but now we want to allow debugging it again, so this reverts that part of the commit. We didnt just revert the commit as it included changes to vscode versions needed to run
…dk and runtime agnostic. Since classes will be running a global install of the sdk and the runtime in the future, it makes sense to rename them now. The word SDK also makes them more verbose. This implements the tests for the global installer resolver. It also makes improvements to said resolver I observed while testing. We never needed, to check for mac conflicting installs as they would be caught by the mac installer. I added a file for the windows and mac installer tests that will be implemented soon.
This also removes some of the remaining todo checks that required verifying that things worked. The windows and mac install tests are failing. Those 2 still need to be fixed.
The directory deletion did not work correctly and the file download would throw with concurrent requests which has been fixed. Passes all library tests. Next the end to end tests should be fixed, todos checked, and code cleaned up.
The e2e test has added an option to not actually do the install via the environment variable `VSCODE_DOTNET_GLOBAL_INSTALL_FAKE_PATH`. We dont want to run the install as it'd put things on our build machines and quickly escalate into a disaster for other repositories. We now set the PATH for a global install because there is no linux installer that sets the path. This also includes minor improvements to other tests like using assert.includes instead of just asserting is true and checking substring.includes.
We added this to assist in the reviewing process.
Also expanded the details for why we use a distro json file.
We do not have logic to do an uninstall for the global install yet, but it's good to be able to check for a partial install and log it nontheless, which is what we do here. We fixed the windows installer to use the installer status exit code instead of stdout because the windows installer does not print to stdout or stderr. We also dont want to fail on reboot success codes. We also cleaned up code by removing unneeded includes. Moving a test string into a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.