Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace try_opt macro with ? #7

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Replace try_opt macro with ? #7

merged 1 commit into from
Aug 25, 2018

Conversation

GabrielMajeri
Copy link
Contributor

@GabrielMajeri GabrielMajeri commented Nov 4, 2017

A recent pull request in Rust made Option<T> work with ?.

This pull request updates the crate to use those features instead of the try_opt! macro.

Note: this shouldn't be merged until this feature stabilises.

@nabijaczleweli
Copy link
Owner

Good to know try_opt crate has a built-in replacement now

@nabijaczleweli
Copy link
Owner

Looks like everything landed and CI builds. Rebase on master, please?

@GabrielMajeri
Copy link
Contributor Author

Sorry, forgot about this, it should be OK now.

@nabijaczleweli nabijaczleweli merged commit 1bfad5a into nabijaczleweli:master Aug 25, 2018
@nabijaczleweli
Copy link
Owner

Lovely, cheers!

@GabrielMajeri GabrielMajeri deleted the try-opt branch August 26, 2018 03:51
@nabijaczleweli
Copy link
Owner

Released in v1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants