Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ISBN value of 0123456789 #8

Closed
wants to merge 1 commit into from
Closed

Conversation

niavasha
Copy link

One of my books was matching this and giving erroneous results, so, quick fix and it works well.

@niavasha
Copy link
Author

done

@na--
Copy link
Owner

na-- commented Jul 1, 2018

Thanks for this! I remember facing a similar issue where several books had 1111111111 or something similar that was a valid ISBN. It was in the beginning of the books and totally broke the metadata fetching... So I like the idea of having some sort of ISBN blacklist, but I'd prefer a more generic and configurable solution.

I think that I'll add a new option for that ISBN blacklist. It will have a sensible default value (including 0123456789 and any ISBNS that contain only the same digit), but users would be able to override it with whatever they want.

@na--
Copy link
Owner

na-- commented Jul 1, 2018

@niavasha, I think I implemented the generic version of this in a somewhat flexible way. Please take a look and see if you like it and if it works as expected.

Thanks for the idea and contribution! I'll close this for now, but feel free to reopen it or open a new PR or issue if you find any problems.

@na-- na-- closed this Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants