Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured Names for sub-switches are missing #235

Open
PrzemyslawKlys opened this issue May 3, 2023 · 3 comments
Open

Configured Names for sub-switches are missing #235

PrzemyslawKlys opened this issue May 3, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@PrzemyslawKlys
Copy link

PrzemyslawKlys commented May 3, 2023

Describe The Bug:
It seems that this plugin is having an issue like most other Homebridge plugins with subswitches under single device being named the same way in homekit. For example I have 4 LG Airconditioners and i see 5 switches under it and all have the same name, so it's pretty hard to know what they actually do.

Similar problems had plugins from HomeConnect and Unifi Protect and you can read about it here:

You can fix it with the information provided in those issues.

To Reproduce:
Just open homekit and go to any device.

Expected behavior:
It should show the name of the device + function it's supposed to turn on/off

Plugin Config:

{
            "country": "PL",
            "language": "pl-PL",
            "auth_mode": "token",
            "platform": "LGThinQ",
            "refresh_token": "98bd",
            "username": "prz",
            "password": "Z",
            "devices": [
                {
                    "id": "37261b78-",
                    "name": "Klimatyzacja Pokoj Lewy",
                    "type": "AC",
                    "ac_air_quality": false,
                    "ac_mode": "BOTH",
                    "ac_swing_mode": "BOTH",
                    "ac_buttons": [
                        {
                            "name": "Auto mode",
                            "op_mode": 6
                        },
                        {
                            "name": "Dry mode",
                            "op_mode": 1
                        },
                        {
                            "name": "Fan mode",
                            "op_mode": 2
                        },
                        {
                            "name": "Air clean",
                            "op_mode": 5
                        }
                    ]
                },
                {
                    "id": "8d00f0",
                    "name": "Klimatyzacja Pokoj Prawy",
                    "type": "AC",
                    "ac_air_quality": false,
                    "ac_mode": "BOTH",
                    "ac_swing_mode": "BOTH",
                    "ac_buttons": [
                        {
                            "name": "Auto mode",
                            "op_mode": 6
                        },
                        {
                            "name": "Dry mode",
                            "op_mode": 1
                        },
                        {
                            "name": "Fan mode",
                            "op_mode": 2
                        },
                        {
                            "name": "Air clean",
                            "op_mode": 5
                        }
                    ]
                },
                {
                    "id": "cbd0e",
                    "name": "Klimatyzacja Sypialnia",
                    "type": "AC",
                    "ac_air_quality": false,
                    "ac_mode": "BOTH",
                    "ac_swing_mode": "BOTH",
                    "ac_buttons": [
                        {
                            "name": "Auto mode",
                            "op_mode": 6
                        },
                        {
                            "name": "Dry mode",
                            "op_mode": 1
                        },
                        {
                            "name": "Fan mode",
                            "op_mode": 2
                        },
                        {
                            "name": "Air clean",
                            "op_mode": 5
                        }
                    ]
                },
                {
                    "id": "f30673",
                    "name": "Klimatyzacja Duzy Pokoj",
                    "type": "AC",
                    "ac_air_quality": false,
                    "ac_mode": "BOTH",
                    "ac_swing_mode": "BOTH",
                    "ac_buttons": [
                        {
                            "name": "Auto mode",
                            "op_mode": 6
                        },
                        {
                            "name": "Dry mode",
                            "op_mode": 1
                        },
                        {
                            "name": "Fan mode",
                            "op_mode": 2
                        },
                        {
                            "name": "Air clean",
                            "op_mode": 5
                        }
                    ]
                }
            ],
            "thinq1": false,
            "refresh_interval": 60,
            "_bridge": {
                "username": "0E:B8:EE:D8:D7:CF",
                "port": 57714
            }
        },

Environment:

  • Plugin Version: 1.5.1
  • Homebridge Version: 1.6.1
  • Node.js Version: 18.16.0
  • NPM Version:
  • Operating System: Ubuntu
@PrzemyslawKlys PrzemyslawKlys added the bug Something isn't working label May 3, 2023
@greycubesgav
Copy link

greycubesgav commented May 8, 2023

+1 for this

Screenshot of the issue I'm seeing, buttons have no prefix in top summary and scrolling down show's blank names for each button bellow:

Screenshot 2023-05-08 at 17 43 14

nVuln pushed a commit that referenced this issue May 12, 2023
@PrzemyslawKlys
Copy link
Author

I saw your commit, thank you for that. I've installed new release but I don't see the change? Am I required to remove all buttons and readd them?

@aabdellah
Copy link
Contributor

I have the same issue, is it possible to hide these buttons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants