Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camel case API #9

Merged
merged 20 commits into from
Jun 21, 2022
Merged

Add camel case API #9

merged 20 commits into from
Jun 21, 2022

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jun 15, 2022

This adds all the API from the old individual python wrappers. The goal here is make the old examples portable by changing only the import statements. So far, I've tested this lib using a python example from RF24/examples_linux (getting_started.py), and it works wonderfully.

Just to reiterate, the old py examples from the individual wrappers can be updated by simply changing

from RF24 import RF24, RF24_PA_LOW
from RF24Network import RF24Network, RF24NetworkHeader

to

from pyrf24 import (
    RF24,
    RF24_PA_LOW,
    RF24Network,
    RF24NetworkHeader,
)

@2bndy5 2bndy5 self-assigned this Jun 15, 2022
@2bndy5 2bndy5 added the enhancement New feature or request label Jun 15, 2022
@2bndy5 2bndy5 marked this pull request as ready for review June 18, 2022 09:35
@2bndy5
Copy link
Member Author

2bndy5 commented Jun 18, 2022

This is well tested now.

Going forward I'd like to make this package the recommended replacement of RF24* python wrappers because it doesn't require users to build and install the C++ libs (its all contained within the python env).

@TMRh20 TMRh20 merged commit ff659b5 into main Jun 21, 2022
@2bndy5 2bndy5 deleted the add-camel-case branch June 21, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants