Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix some vue warnings (no-changelog) #9069

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: Fix some vue warnings (no-changelog) #9069

merged 2 commits into from
Apr 8, 2024

Conversation

tomi
Copy link
Collaborator

@tomi tomi commented Apr 5, 2024

Summary

  • fix(editor): Fix missing required prop: "unresolvedExpression" warning

image

  • fix(editor): Fix prop type check failed for prop "icon" warning

image

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Apr 5, 2024
netroy
netroy approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

@cypress Cypress
Copy link

cypress bot commented Apr 5, 2024 •
edited
Loading

3 flaky tests on run #4615 ↗︎

0 353 12 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project: n8n Commit: 00dc3e2c8d
Status: Passed Duration: 04:14 💡
Started: Apr 8, 2024 9:53 AM Ended: Apr 8, 2024 9:58 AM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  15-scheduler-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Schedule Trigger node > should execute once per second when activated Test Replay Screenshots Video

Review all test suite changes for PR #9069 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@tomi tomi force-pushed the fix-some-vue-warnings branch from 541301b to 00dc3e2 Compare April 8, 2024 06:57
@tomi tomi requested a review from netroy April 8, 2024 09:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

✅ All Cypress E2E specs passed

@tomi tomi merged commit 50dd90d into master Apr 8, 2024
28 checks passed
@tomi tomi deleted the fix-some-vue-warnings branch April 8, 2024 10:08
@janober
Copy link
Member

janober commented Apr 10, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomi @janober @netroy