fix(core): Improve domain and url matching for extractDomain and extractUrl #6045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…input # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
n8n-assistant
bot
added
core
…evert-6010-ado-476-bug-extractdomain-breaks-when-the-input
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6045 +/- ##
==========================================
- Coverage 18.71% 18.71% -0.01%
==========================================
Files 2582 2582
Lines 116510 116513 +3
Branches 18178 18179 +1
==========================================
- Hits 21805 21804 -1
- Misses 94067 94071 +4
Partials 638 638
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #6010 to add breaking changes footer