Skip to content

fix(editor): Clean up demo and template callouts from workflows page #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix(editor): Clean up demo and template callouts from workflows page #6023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f472b
fix(editor): clean up demo callouts
mutdmour Apr 20, 2023
5b9aa49
fix(editor): clean up i18n
mutdmour Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/editor-ui/src/plugins/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1566,10 +1566,6 @@
"workflows.empty.heading.userNotSetup": "👋 Welcome!",
"workflows.empty.description": "Create your first workflow",
"workflows.empty.startFromScratch": "Start from scratch",
"workflows.empty.browseTemplates": "Browse templates",
"workflows.empty.viewDemo": "View a demo workflow",
"workflows.viewDemoNotice": "Learn automation key concepts with our demo workflow",
"workflows.viewDemo": "View demo workflow",
"workflows.shareModal.title": "Share '{name}'",
"workflows.shareModal.select.placeholder": "Add users...",
"workflows.shareModal.list.delete": "Remove access",
Expand Down
25 changes: 0 additions & 25 deletions packages/editor-ui/src/views/WorkflowsView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,6 @@
@click:add="addWorkflow"
@update:filters="filters = $event"
>
<template #callout v-if="!hasActiveWorkflows">
<n8n-callout theme="secondary" icon="graduation-cap" class="mb-xs">
{{ $locale.baseText('workflows.viewDemoNotice') }}

<template #trailingContent>
<n8n-link size="small" theme="secondary" bold underline @click="goToTemplates">
{{ $locale.baseText('workflows.viewDemo') }}
</n8n-link>
</template>
</n8n-callout>
</template>
<template #default="{ data, updateItemSize }">
<workflow-card
data-test-id="resources-list-item"
Expand Down Expand Up @@ -59,17 +48,6 @@
{{ $locale.baseText('workflows.empty.startFromScratch') }}
</n8n-text>
</n8n-card>
<n8n-card
:class="$style.emptyStateCard"
hoverable
@click="goToTemplates"
data-test-id="new-workflow-template-card"
>
<n8n-icon :class="$style.emptyStateCardIcon" icon="graduation-cap" />
<n8n-text size="large" class="mt-xs" color="text-base">
{{ $locale.baseText('workflows.empty.viewDemo') }}
</n8n-text>
</n8n-card>
</div>
</template>
<template #filters="{ setKeyValue }">
Expand Down Expand Up @@ -209,9 +187,6 @@ const WorkflowsView = mixins(showMessage, debounceHelper).extend({
source: 'Workflows list',
});
},
goToTemplates() {
this.$router.push({ name: VIEWS.TEMPLATES });
},
async initialize() {
await Promise.all([
this.usersStore.fetchUsers(),
Expand Down